Skip to content

feat: Operate website proxy config#12005

Merged
zhengkunwang223 merged 5 commits into1Panel-dev:dev-v2from
moeshin:moeshin/feat-operate-website-proxy
Mar 3, 2026
Merged

feat: Operate website proxy config#12005
zhengkunwang223 merged 5 commits into1Panel-dev:dev-v2from
moeshin:moeshin/feat-operate-website-proxy

Conversation

@moeshin
Copy link
Contributor

@moeshin moeshin commented Mar 1, 2026

What this PR does / why we need it?

当反代配置不是常规配置的情况下，会出现无法暂停、删除的问题。
这主要是接口入参校验导致的。

image

Summary of your change

新增一个操作接口，只传必要的值。

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 1, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@moeshin moeshin marked this pull request as draft March 2, 2026 00:01
@moeshin moeshin marked this pull request as ready for review March 2, 2026 02:27
@HynoR
Copy link
Contributor

HynoR commented Mar 2, 2026 •
edited
Loading

拆开这个operate接口的想法很好，不过拆成两个接口operate 和 update 很容易混淆，这个接口本来就难读，虽然解决了问题但是后面开发的时候读这段挺容易迷惑的。

个人感觉如果要改最好彻底点。要么不拆接口。把dto 里的字段去掉required 标签，然后通过service代码手动判断拦截或者屏蔽来分类会不会更精简？

或者如果要拆接口，做绝一点直接一个操作一个接口来分割职责，然后每个接口用自己的规范dto。

仅本人意见，这种拆一半来解决问题的方法不是很好

@zhengkunwang223
Copy link
Member

zhengkunwang223 commented Mar 2, 2026

delete 和 enable/disable 接口分开写会更好一些
各司其职

@moeshin moeshin marked this pull request as draft March 2, 2026 06:43
moeshin
moeshin commented Mar 2, 2026
View reviewed changes
@moeshin moeshin marked this pull request as ready for review March 2, 2026 19:15
@f2c-ci-robot f2c-ci-robot bot requested a review from wanghe-fit2cloud March 2, 2026 19:15
@zhengkunwang223 zhengkunwang223 merged commit 8c33eb8 into 1Panel-dev:dev-v2 Mar 3, 2026
0 of 3 checks passed
moeshin added a commit to moeshin/1Panel that referenced this pull request Mar 3, 2026
@moeshin
feat: Operate website proxy config (1Panel-dev#12005)
c8163ed 
* feat: Operate website proxy config

* chore: Update api comment

* chore: update swagger

* chore: update x-log

* feat: split api
moeshin added a commit to moeshin/1Panel that referenced this pull request Mar 3, 2026
@moeshin
feat: Operate website proxy config (1Panel-dev#12005)
f04fae6 
* feat: Operate website proxy config

* chore: Update api comment

* chore: update swagger

* chore: update x-log

* feat: split api
@moeshin moeshin mentioned this pull request Mar 3, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssongliu ssongliu Awaiting requested review from ssongliu

@zhengkunwang223 zhengkunwang223 Awaiting requested review from zhengkunwang223

@wanghe-fit2cloud wanghe-fit2cloud Awaiting requested review from wanghe-fit2cloud

Assignees

No one assigned

Labels

do-not-merge/release-note-label-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moeshin @HynoR @zhengkunwang223